Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ims Org ID #1611

Merged
merged 2 commits into from
Aug 14, 2024
Merged

Ims Org ID #1611

merged 2 commits into from
Aug 14, 2024

Conversation

BaskarMitrah
Copy link
Collaborator

Description

Added Ims Org ID in the credential card

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Collaborator

@deepessh deepessh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BaskarMitrah please add e2e tests for the new field

Comment on lines 1 to 8
import React from 'react';
import ShowCard from '../Card/ShowCard';

const ReturnImsOrgID = ({ returnImsOrgID , imsOrgId , value}) => {
return <ShowCard heading={returnImsOrgID?.heading} value={value} />;
};

export { ReturnImsOrgID };
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate of packages/gatsby-theme-aio/src/components/GetCredential/Card/CardImsOrgID.js. Can we merge them into one?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay

@timkim timkim merged commit 46c3b8b into main Aug 14, 2024
3 checks passed
@timkim timkim deleted the bugs/credential/add-imsOrgID branch August 14, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants